-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
graphql: Minor delete mutation msg fix #5316
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine.
But looks like there's some other places in tests where that message was being relied on.
Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @manishrjain)
…te-mutation-msg-fix
…te-mutation-msg-fix # Conflicts: # graphql/resolve/mutation.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!!! Love it.
Merge this and then either fix or remove that TODO.
Reviewed 4 of 4 files at r2.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @manishrjain and @vardhanapoorv)
ee/acl/acl_test.go, line 90 at r2 (raw file):
func deleteUser(t *testing.T, accessToken, username string, confirmDeletion bool) { // TODO - Verify that only one uid got deleted once numUids are returned as part of the payload.
Can we also fix this TODO ? Just merge this PR and do separately.
ee/acl/acl_test.go, line 169 at r2 (raw file):
func TestGetCurrentUser(t *testing.T) { accessJwt, _ := testutil.GrootHttpLogin(adminEndpoint)
Thanks - always good to see code get cleaned up.
ee/acl/acl_test.go, line 199 at r2 (raw file):
// adding the user again should fail accessJwt, _ := testutil.GrootHttpLogin(adminEndpoint)
again nice simplification. - looks like there has been some repeated code in here.
graphql/e2e/common/mutation.go, line 2298 at r2 (raw file):
func cleanupStarwars(t *testing.T, starshipID, humanID, droidID string) { // Delete everything multiMutationParams := &GraphQLParams{
love it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @manishrjain, @MichaelJCompton, and @vardhanapoorv)
ee/acl/acl_test.go, line 90 at r2 (raw file):
Previously, MichaelJCompton (Michael Compton) wrote…
Can we also fix this TODO ? Just merge this PR and do separately.
Ok, will do it separately.
This PR changes the delete msg reported for the case when no nodes are deleted to No nodes were deleted. In addition, it corrects some tests which were wrong earlier. Fixes #GRAPHQL-423. Co-authored-by: Abhimanyu Singh Gaur <12651351+abhimanyusinghgaur@users.noreply.github.com> (cherry picked from commit 47f2f51) # Conflicts: # ee/acl/acl_test.go # graphql/e2e/auth/auth_test.go # graphql/e2e/common/mutation.go # graphql/resolve/mutation.go
This PR changes the delete msg reported for the case when no nodes are deleted to No nodes were deleted. In addition, it corrects some tests which were wrong earlier. Fixes #GRAPHQL-465. (cherry picked from commit 47f2f51) # Conflicts: # ee/acl/acl_test.go # graphql/e2e/auth/auth_test.go # graphql/e2e/common/mutation.go # graphql/resolve/mutation.go
This PR changes the delete msg reported for the case when no nodes are deleted to No nodes were deleted. In addition, it corrects some tests which were wrong earlier. Fixes #GRAPHQL-423. Co-authored-by: Abhimanyu Singh Gaur <12651351+abhimanyusinghgaur@users.noreply.github.com>
This PR changes the delete msg reported for the case when no nodes are deleted to
No nodes were deleted
. In addition, it corrects some tests which were wrong earlier.Fixes #GRAPHQL-423.
This change is
Docs Preview: